Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create login page #1394

Draft
wants to merge 24 commits into
base: ui/redesign
Choose a base branch
from
Draft

Create login page #1394

wants to merge 24 commits into from

Conversation

pedroafmonteiro
Copy link
Contributor

@pedroafmonteiro pedroafmonteiro commented Nov 19, 2024

Closes #1375

  • Login page layout
  • Widgets (Login, Remember, Problems and Terms and Conditions) new design
  • Implement splash screen
  • Login with credentials popup

To implement the splash screen

  • To add the gradient and animation to the splash screen I needed to add this package, because it allow us to create a splash screen with custom widgets for the gradients and the animation: https://pub.dev/packages/another_flutter_splash_screen This was accomplished without adding the package.

  • The native splash screen was replaced by the same background color as the new splash and login page with a transparent logo image through this package. I think that, before, both the android and ios splash screens were implemented manually, but this package does that automatically with a simple configuration in the pubspec.yaml file: https://pub.dev/packages/flutter_native_splash

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

textSelectionTheme: const TextSelectionThemeData(
cursorColor: Colors.white,
selectionHandleColor: Colors.white,
data: applicationLightTheme.copyWith(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this must be inserted into the theme directly, once it is finished.

fromHeroContext,
toHeroContext,
) {
return ScaleTransition(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this transition? Can you upload a "demo"?

Copy link
Contributor Author

@pedroafmonteiro pedroafmonteiro Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sent it as a video in the issue page, but here it is:
https://github.com/user-attachments/assets/12611925-2dc3-45bb-b13a-136a582c9b23

As there's not a splash screen yet, there's no Hero linking transition widget :/

@pedroafmonteiro pedroafmonteiro linked an issue Nov 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 7.26257% with 166 lines in your changes missing coverage. Please review.

Project coverage is 12%. Comparing base (92e33f6) to head (182847b).
Report is 1 commits behind head on ui/redesign.

Additional details and impacted files
@@             Coverage Diff             @@
##           ui/redesign   #1394   +/-   ##
===========================================
- Coverage           12%     12%   -0%     
===========================================
  Files              265     270    +5     
  Lines             7209    7286   +77     
===========================================
+ Hits               806     808    +2     
- Misses            6403    6478   +75     

@pedroafmonteiro
Copy link
Contributor Author

I implemented the splash screen without the "another_flutter_splash_screen" package.
There's an issue though. A black screen appears between the Splash Screen view and the next screen (login or homepage)

@pedroafmonteiro
Copy link
Contributor Author

pedroafmonteiro commented Dec 4, 2024

there's a linting problem, as Tween() asks for doubles, but if I put ints, it gives an error and I can't cast it as Animation because it stops working
it's now fixed, but login_old.dart is giving problems now

@thePeras
Copy link
Member

thePeras commented Dec 8, 2024

@pedroafmonteiro if login_old.dart is giving you problems and isn't bing use, just delete it!

@thePeras
Copy link
Member

thePeras commented Dec 9, 2024

If it's already ready to review, just convert the PR to "already to review". I am excited to look into this.

@pedroafmonteiro
Copy link
Contributor Author

The login with credentials popup is the only thing left. It should be done between today and tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new login page
4 participants